ArangoDB module was added #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/modules/neo4j/neo4j-container.ts
Outdated
| @@ -30,6 +30,10 @@ export class Neo4jContainer extends GenericContainer { | |||
| ); | |||
| } | |||
|
|
|||
| public withTtl(schedule = 5) { | |||
There was a problem hiding this comment.
was this not already merged into master?
There was a problem hiding this comment.
Yes, this is weird. I can't see any difference here. Do you know how to remove this from the pull? When I checkout the file from the base branch it doesn't show any modificationn
There was a problem hiding this comment.
seems there's a conflict here now
There was a problem hiding this comment.
I don't get a conflict here
|
thanks @ltwlf, just a few questions/comments 🙂 |
|
just a couple comments about the README and a conflict to resolve, once addressed lgtm 👍 |
cristianrgreco
approved these changes
Aug 15, 2020
|
great stuff! let me know if it's ready to release |
|
Fine for me :) |
|
released in 3.4.0 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was rather simple :)