-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Colima #531
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I've been looking into what it would take to get this working for Java as well, though it sounds like @eddumelendez might take care of that once this is done. Just out of curiosity, is the issue that waiting for log lines just isn't good enough for Colima, and you have to use a port-based wait strategy instead in practice? |
Hi @glasser, I've just updated the PR comment with all the info |
The goal of this PR was to integrate support for Colima into testcontainers-node such that we could run the entire test suite with Colima as part of our CICD. As of 19/04/2023 this isn't possible for the following reasons:
2.1. We intermittently see Docker pull rate limits for official images, such as Mongo, PostgreSQL, etc (?!).
2.2. Dockerfiles which install dependencies when built are randomly unable to resolve dependencies, such as curl.
2.3. I have had to increase timeouts of some test suites by a multiplier, so that the tests complete in time.
To re-emphasise, because of the way GH have structured its runners, I cannot rule out that a lot of the issues I've faced are because of the MacOS runners.
This comment is not to say that Colima is unsupported, it means that your mileage may vary. I will soon document some of these issues and workarounds in the official docs, and depending on your use cases and environment, Colima may work without issue.
I will re-visit Colima support in the future. In the meantime if I have missed anything, or someone is able to improve Colima support in testcontainers-node, any contributions are very welcome!