Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Testcontainers Host #564

Merged
merged 8 commits into from
May 11, 2023
Merged

Add support for Testcontainers Host #564

merged 8 commits into from
May 11, 2023

Conversation

cristianrgreco
Copy link
Collaborator

@cristianrgreco cristianrgreco commented May 10, 2023 •
edited
Loading

  1. Adds a strategy similar to the configuration strategy.
  2. The functions which resolve host/remote docker unix socket now accept a allowUserOverrides parameter which conditionally discards environment variables. This parameter is set by the strategy.

@cristianrgreco cristianrgreco added enhancement New feature or request minor Backward compatible functionality labels May 10, 2023
@cristianrgreco cristianrgreco self-assigned this May 10, 2023
@netlify
Copy link

netlify bot commented May 10, 2023 •
edited
Loading

✅ Deploy Preview for testcontainers-node ready!

Name Link
🔨 Latest commit b3f7766
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-node/deploys/645cdb522d9e820008d442ea
😎 Deploy Preview https://deploy-preview-564--testcontainers-node.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cristianrgreco cristianrgreco marked this pull request as ready for review May 10, 2023 09:10
@cristianrgreco cristianrgreco marked this pull request as draft May 10, 2023 11:05
@cristianrgreco cristianrgreco marked this pull request as ready for review May 10, 2023 13:35
@cristianrgreco cristianrgreco changed the title Add support for Testcontainers Cloud Add support for Testcontainers Host May 11, 2023
@cristianrgreco cristianrgreco merged commit 98983bd into main May 11, 2023
@cristianrgreco cristianrgreco deleted the tcc-strategy branch May 11, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

@HofmeisterAn HofmeisterAn HofmeisterAn approved these changes

Assignees

@cristianrgreco cristianrgreco

Labels
enhancement New feature or request minor Backward compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cristianrgreco @kiview @HofmeisterAn