-
-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ollama module #778
Add ollama module #778
Conversation
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
.withWaitStrategy(Wait.forLogMessage("Listening on ")) | ||
.withStartupTimeout(120_000); | ||
|
||
getContainerRuntimeClient().then((client) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although this should be fine because the container runtime client will be initialised before this constructor is invoked, it is still async and not guaranteed to resolve before start
is called. I'd move this into the start
method or one of the other lifecycle callbacks where it can be awaited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Cristian :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Ignasi!
adds Ollama Module based on module of TC java