Add support for specifying image platform #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to the pass `--platform`-argument for the docker container refs testcontainers#773
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
weyert
commented
Jul 28, 2024
packages/testcontainers/src/generic-container/generic-container.test.ts
Outdated
Show resolved
Hide resolved
cristianrgreco
added
enhancement
cristianrgreco
changed the title
withPlatform-function to TestContainerUpdated the `image-client` so it also allows passing the `platform` configuration option to `dockerode`
| @@ -123,6 +123,19 @@ describe("GenericContainer", () => { | |||
| expect(output).toEqual(expect.stringContaining("/tmp")); | |||
| }); | |||
|
|
|||
| it("should set platform", async () => { | |||
| // This test uses an older version of cristianrgreco/testcontainer as all the other tests are using the latest version and the code doesn't pull the image again when the platform differs at this time | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Thanks. I have updated it.
packages/testcontainers/src/generic-container/generic-container.test.ts
Outdated
Show resolved
Hide resolved
|
@cristianrgreco Anything else needed to get this merged? |
|
@cristianrgreco I updated the documentation to add a callout to the new |
|
@cristianrgreco Any more changes needed? Love to stop using my fork of this package :) |
cristianrgreco
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to the pass
--platform-argument for the docker containerfixes #773