-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem mounting volumes after revamp #580
Comments
Thanks for reporting! Yeah, this should be fixed. Interestingly, no one has used an http client with volumes before (that part hasn't actually been changed). Feel free to open PR if you wish. Otherwise I'll address this a bit later |
ns-sjorgedeaguiar
added a commit
to ns-sjorgedeaguiar/testcontainers-rs
that referenced
this issue
Apr 23, 2024
The volumes option is used for anonymous volumes, whereas the binds is the one that accepts a list of `{local}:{remote}` paths. Fixes testcontainers#580.
ns-sjorgedeaguiar
added a commit
to ns-sjorgedeaguiar/testcontainers-rs
that referenced
this issue
Apr 23, 2024
The volumes option is used for anonymous volumes, whereas the binds is the one that accepts a list of `{local}:{remote}` paths. Fixes testcontainers#580.
github-merge-queue bot
pushed a commit
that referenced
this issue
Apr 23, 2024
The volumes option is used for anonymous volumes, whereas the binds is the one that accepts a list of `{local}:{remote}` paths. Fixes #580.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I was testing the new version after #575 and mounting is not working with custom images.
The problem seems to be because the runner sets the
volumes
config option:However that option is meant for anonymous volume mounts, where the keys are the path inside the container and the values are an empty map.
The
binds
hostconfig option is the one accepting a list of mounts. Replacing the above by something like this works:The text was updated successfully, but these errors were encountered: