Add package.json scripty options support for npm7

[Chocobozzz]

Closes #93

[jasonkarns]

Looks good so far. Does npm7 document or guarantee that package_json_path will be absolute?

[rosston]

@jasonkarns I'm not sure it's a guarantee, but the RFC says that npm_package_json will come from @npmcli/run-script, which uses resolve in its implementation and therefore provides an absolute path.

[jasonkarns]

Just a single nitpick: typically prefer to camelCase function names, which necessitates lowercasing the N+1 chars of an initialism. so packageJson instead of packageJSON

Do you also have a rationale for expanding the if/elseif into distinct if conditionals? Functionally, they're the same; though "spiritually" they are a single if-elseif statement. If JavaScript had expression-valued-conditionals, ala ruby, it would be a single if-elseif by necessity.

Otherwise, I'm 👍 and appreciative!

[Chocobozzz]

Do you also have a rationale for expanding the if/elseif into distinct if conditionals? Functionally, they're the same; though "spiritually" they are a single if-elseif statement. If JavaScript had expression-valued-conditionals, ala ruby, it would be a single if-elseif by necessity.

Not really, it's just that with 4 if I found that it was more readable to understand the multiple fallbacks. Thanks @jasoncaryallen for the review and the fixes :)

[Chocobozzz]

Any news @jasonkarns? :)

[ben8p]

Is scripty still maintained ?

This is quite of a blocker for people using npm 7

[rosston]

Closing because I think this is resolved in scripty 2.1.0 (via #105). Feel free to comment/reopen if this is not actually fixed!