Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make histogram buckets expression as comma-separated #101

Closed
testillano opened this issue Aug 4, 2023 · 0 comments
Closed

Make histogram buckets expression as comma-separated #101

testillano opened this issue Aug 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@testillano
Copy link
Owner

Is your feature request related to a problem? Please describe.
Currently, histogram buckets provided to h2agent and udp-server-h2client, are space-separated list of bucket boundaries:
--prometheus-response-delay-seconds-histogram-boundaries "100e-6 200e-6 300e-6 400e-6 500e-6 1e-3 5e-3 10e-3 20e-3"

This implies some problems when developing bash scripts and trying to pass them through functions as $@ or isolated arguments.

Describe the solution you'd like
So, we consider better (and more readable) to make it like a single string, as comma-separated:

--prometheus-response-delay-seconds-histogram-boundaries "100e-6,200e-6,300e-6,400e-6,500e-6,1e-3,5e-3,10e-3,20e-3"
@testillano testillano added the enhancement New feature or request label Aug 4, 2023
testillano added a commit that referenced this issue Aug 5, 2023
@testillano
Implement multiple patterns in udp-server-h2client
7cbdda8 
Allow to provide multiple patterns to udp-server-h2client,
which will be selected by rand() algorithm [0].

Also, histogram buckets are now provided as a comma-separated
list, to avoid problems parsing bash arguments as space-separated [1].

Finally, we upgrade to http2comm v2.1.3 to have dynamic counter for
response status codes [2].

[0] #100
[1] #101
[2] testillano/http2comm#22
testillano added a commit that referenced this issue May 13, 2024
@testillano
Implement multiple patterns in udp-server-h2client
d3d8a81 
Allow to provide multiple patterns to udp-server-h2client,
which will be selected by rand() algorithm [0].

Also, histogram buckets are now provided as a comma-separated
list, to avoid problems parsing bash arguments as space-separated [1].

Finally, we upgrade to http2comm v2.1.3 to have dynamic counter for
response status codes [2].

[0] #100
[1] #101
[2] testillano/http2comm#22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@testillano