feat: [prefer-in-document] Detect and auto-fix 'toBeFalsy()' and 'toB…

…eTruthy()' (#172)
testing-library · May 10, 2021 · fae4203 · fae4203
1 parent 85a3a20
commit fae4203
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 1 deletion.
diff --git a/docs/rules/prefer-in-document.md b/docs/rules/prefer-in-document.md
@@ -21,6 +21,10 @@ expect(queryByText("foo")).toEqual(null);
 expect(queryByText("foo")).not.toEqual(null);
 expect(queryByText("foo")).toBeDefined();
 expect(queryByText("foo")).not.toBeDefined();
+expect(queryByText("foo")).toBeTruthy();
+expect(queryByText("foo")).not.toBeTruthy();
+expect(queryByText("foo")).toBeFalsy();
+expect(queryByText("foo")).not.toBeFalsy();
 
 const foo = screen.getByText("foo");
 expect(foo).toHaveLength(1);

diff --git a/src/__tests__/lib/rules/prefer-in-document.js b/src/__tests__/lib/rules/prefer-in-document.js
@@ -268,6 +268,22 @@ const invalid = [
     `expect(queryByText('foo')) .not .toBeDefined()`,
     `expect(queryByText('foo')) .not .toBeInTheDocument()`
   ),
+  invalidCase(
+    `expect(queryByText('foo')).toBeFalsy()`,
+    `expect(queryByText('foo')).not.toBeInTheDocument()`
+  ),
+  invalidCase(
+    `expect(queryByText('foo')).not.toBeFalsy()`,
+    `expect(queryByText('foo')).toBeInTheDocument()`
+  ),
+  invalidCase(
+    `expect(queryByText('foo')).toBeTruthy()`,
+    `expect(queryByText('foo')).toBeInTheDocument()`
+  ),
+  invalidCase(
+    `expect(queryByText('foo')).not.toBeTruthy()`,
+    `expect(queryByText('foo')).not.toBeInTheDocument()`
+  ),
   invalidCase(
     `let foo;
       foo = screen.queryByText('foo');

diff --git a/src/rules/prefer-in-document.js b/src/rules/prefer-in-document.js
@@ -26,6 +26,7 @@ export const meta = {
 function isAntonymMatcher(matcherNode, matcherArguments) {
   return (
     matcherNode.name === "toBeNull" ||
+    matcherNode.name === "toBeFalsy" ||
     usesToBeOrToEqualWithNull(matcherNode, matcherArguments) ||
     usesToHaveLengthZero(matcherNode, matcherArguments)
   );
@@ -43,7 +44,7 @@ function usesToHaveLengthZero(matcherNode, matcherArguments) {
 }
 
 export const create = (context) => {
-  const alternativeMatchers = /^(toHaveLength|toBeDefined|toBeNull|toBe|toEqual)$/;
+  const alternativeMatchers = /^(toHaveLength|toBeDefined|toBeNull|toBe|toEqual|toBeTruthy|toBeFalsy)$/;
   function getLengthValue(matcherArguments) {
     let lengthValue;