Skip to content

Commit

Permalink
chore: revert node 10.22.1 as minimum version
Browse files Browse the repository at this point in the history
Minimum node version required for using the plugin is still 10.12 but it
was up to 10.22.1 because of a dev dependency. This won't affect usages
of the plugin so I'm reverting it.
More details here: #234
  • Loading branch information
Belco90 committed Apr 11, 2021
1 parent b5b93a4 commit 8f2e0a5
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ jobs:

strategy:
matrix:
node: [ '10.22.1', '10', '12', '14' ]
eslint: [ '7.5', '7', ]
node: [ 10.12, 10, 12, 14 ]
eslint: [ 7.5, 7 ]

steps:
- name: Cancel Previous Runs
Expand Down
4 changes: 2 additions & 2 deletions docs/migrating-to-v4-guide.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ One of the most important changes of `eslint-plugin-testing-library` v4 is the n

### Dependencies

- Min Node version required is `10.22.1`
- Min ESLint version required is `7.5`
- Min Node version required didn't change (`10.12`)

Make sure you have Node and ESLint installed satisfying these new required versions.
Please make sure you have Node and ESLint installed satisfying these required versions.

### New errors reported

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
"eslint": "^7.5.0"
},
"engines": {
"node": "^10.22.1 || >=12.0.0",
"node": "^10.12.0 || >=12.0.0",
"npm": ">=6"
},
"license": "MIT"
Expand Down

0 comments on commit 8f2e0a5

Please sign in to comment.