Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v5.0.0 #471

Merged
merged 16 commits into from
Oct 25, 2021
Merged

v5.0.0 #471

merged 16 commits into from
Oct 25, 2021

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Sep 6, 2021

This PR contains all of the changes for v5.0.0.
This branch will be rebased-merged on top of master for the release.

Because we need to ensure we're handling all breaking changes from ESLint v8 - we cannot release this until ESLint v8 is officially released.
That being said - this branch is released to NPM! You can install it via the alpha tag.

  • Add migration guide to v5

Changelog

  • Drop support for Node v10 - required node version is now ^12.22.0 || ^14.17.0 || >=16.0.0.
    • Node v10 was EOL'd in April 2021, and ESLint v8 dropped support for it too.
  • Support for ESLint v8
  • Update dependencies
  • no-debug is now called no-debugging-utils
  • no-render-in-setup is now enabled by default in the Angular, React & Vue configs
  • no-unnecessary-act's isStrict option is now true by default
  • no-unnecessary-act is now enabled by default in the React config
  • no-wait-for-multiple-assertions is now enabled by default in all configs
  • no-wait-for-side-effects is now enabled by default in all configs
  • no-wait-for-snapshot is now enabled by default in all configs
  • prefer-presence-queries is now enabled by default in all configs
  • prefer-query-by-disappearance is now enabled by default in all configs

Closes #478

@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label Sep 6, 2021
@MichaelDeBoey MichaelDeBoey added this to the 5.0.0 milestone Sep 6, 2021
@MichaelDeBoey MichaelDeBoey self-assigned this Sep 6, 2021
@Belco90
Copy link
Member

Belco90 commented Oct 13, 2021

⚠️ Important: we should avoid squashing this PR when merged, so we respect all the commits from each individual PR, specially for the release changelog.

MichaelDeBoey and others added 8 commits October 14, 2021 00:23
BREAKING CHANGE: Requires Node@^12.22.x || ^14.17.x || >=16.x
BREAKING CHANGE: `no-debug` is now called `no-debugging-utils`
BREAKING CHANGE: `no-unnecessary-act` is now enabled by default in the React config (with `isStrict` set to `true`)
…ult (#481)

BREAKING CHANGE: `no-render-in-setup` is now enabled by default in the Angular, React & Vue configs
…483)

BREAKING CHANGE: `no-wait-for-multiple-assertions` is now enabled by default in all configs
BREAKING CHANGE: `no-wait-for-side-effects` is now enabled by default in all configs
BREAKING CHANGE: `no-wait-for-snapshot` is now enabled by default in all configs
BREAKING CHANGE: `prefer-presence-queries` is now enabled by default in all configs
)

BREAKING CHANGE: `prefer-query-by-disappearance` is now enabled by default in all configs
@Belco90 Belco90 self-requested a review October 14, 2021 00:01
MichaelDeBoey and others added 2 commits October 14, 2021 03:21
* feat: support ESLint 8.x

* feat: support ESLint 8.x

* chore: downgrade ESLint to v7 in dev deps

* ci: force deps installation for running tests

Co-authored-by: Mario Beltrán Alarcón <belco90@gmail.com>
@Belco90
Copy link
Member

Belco90 commented Oct 17, 2021

Everything should be ok now. I'm gonna add a "migration guide to v5" doc, and should be ready to go!

@Belco90 Belco90 added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation labels Oct 17, 2021
@Belco90
Copy link
Member

Belco90 commented Oct 17, 2021

I've tested the alpha-10 version of the plugin in a repo of mine and works great for both ESLint v7 and v8!

@Belco90 Belco90 marked this pull request as ready for review October 17, 2021 19:26
@Belco90
Copy link
Member

Belco90 commented Oct 17, 2021

Migration guide added, this is ready to go now! What do you think @MichaelDeBoey?

timdeschryver
timdeschryver previously approved these changes Oct 18, 2021
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Seems like it was a smooth upgrade, good to know 🙂

@Belco90 Belco90 merged commit b510bd4 into main Oct 25, 2021
@Belco90 Belco90 deleted the alpha branch October 25, 2021 14:38
@github-actions
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking changes for next v5
3 participants