Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ESLint v9 #928

Merged
merged 1 commit into from
Oct 18, 2024
Merged

feat: support ESLint v9 #928

merged 1 commit into from
Oct 18, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Aug 15, 2024

Checks

Changes

  • adds ESLint v9 as an allowed peer dependency

Context

v9 can be officially supported given that #926 has the plugin running against v9 without issue

@G-Rath G-Rath changed the title Allow v9 feat: allow ESLint v9 Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.33%. Comparing base (93a6ab9) to head (3d3f99f).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
+ Coverage   96.23%   96.33%   +0.09%     
==========================================
  Files          44       46       +2     
  Lines        2419     2481      +62     
  Branches     1000     1023      +23     
==========================================
+ Hits         2328     2390      +62     
  Misses         91       91              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niklaas
Copy link

niklaas commented Oct 15, 2024

Is this the proper PR to subscribe to for getting updated about making this plugin compatible working with eslint v9? I'm asking because it's been in draft state since August. Anything I could potentially help with to get it into review state?

@G-Rath
Copy link
Contributor Author

G-Rath commented Oct 15, 2024

@niklaas this is good to go but currently a draft as it's branched off of #926 (which proves the plugin works with ESLint v9) and in turn that's branched off of #925 (which is the runtime fix required for the plugin to work with v9) - I've done them as dedicated PRs as I feel it's nice to have them in their own commits and released independently in case something comes up along the line.

While @Belco90 doesn't have to land my PRs, I suspect that he'll be happy with them so I think it's the one to subscribe to - alternatively you could subscribe to releases for this whole codebase since it's most likely the next release will include v9 support:

image
image

@niklaas
Copy link

niklaas commented Oct 16, 2024

Thanks a lot! Appreciated the update. 🙇🏼

@G-Rath G-Rath force-pushed the allow-v9 branch 4 times, most recently from dedc096 to f9013e3 Compare October 17, 2024 22:58
@G-Rath G-Rath marked this pull request as ready for review October 18, 2024 01:20
@Belco90 Belco90 changed the title feat: allow ESLint v9 feat: support ESLint v9 Oct 18, 2024
@Belco90 Belco90 enabled auto-merge October 18, 2024 05:56
@Belco90 Belco90 added this pull request to the merge queue Oct 18, 2024
Merged via the queue into testing-library:main with commit 657ed01 Oct 18, 2024
41 checks passed
Copy link

🎉 This PR is included in version 6.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants