-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ESLint v9 #928
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #928 +/- ##
==========================================
+ Coverage 96.23% 96.33% +0.09%
==========================================
Files 44 46 +2
Lines 2419 2481 +62
Branches 1000 1023 +23
==========================================
+ Hits 2328 2390 +62
Misses 91 91 ☔ View full report in Codecov by Sentry. |
Is this the proper PR to subscribe to for getting updated about making this plugin compatible working with eslint v9? I'm asking because it's been in draft state since August. Anything I could potentially help with to get it into review state? |
@niklaas this is good to go but currently a draft as it's branched off of #926 (which proves the plugin works with ESLint v9) and in turn that's branched off of #925 (which is the runtime fix required for the plugin to work with v9) - I've done them as dedicated PRs as I feel it's nice to have them in their own commits and released independently in case something comes up along the line. While @Belco90 doesn't have to land my PRs, I suspect that he'll be happy with them so I think it's the one to subscribe to - alternatively you could subscribe to releases for this whole codebase since it's most likely the next release will include v9 support: |
Thanks a lot! Appreciated the update. 🙇🏼 |
dedc096
to
f9013e3
Compare
🎉 This PR is included in version 6.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Checks
Changes
Context
v9 can be officially supported given that #926 has the plugin running against v9 without issue