Convert to TypeScript #520

juhanakristian · 2020-12-14T09:14:00Z

What:

Converting library to TypeScript, issue #498
Removes deprecated wait util (as per discussion in KCD Discord)
https://discord.com/channels/715220730605731931/785649901782433852/786338242101379142

Creating this PR on behalf of @tigerabrodi we and other people from KCD Discord are going to work on it as a group

Checklist:

Documentation updated
Tests
Ready to be merged
Added myself to contributors table

this can be reverted when `pure.js` is converted to typescript

just a rename 😅

…/no-unresolved for now

- see: https://prettier.io/blog/2020/08/24/2.1.0.html\#type-annotations-on-catch-clauses-8805httpsgithubcomprettierprettierpull8805-by-fiskerhttpsgithubcomfisker - Updated prettier in local devDeps to resolve directly to newest supported version

… operator TS expecting explicit return of undefined from arrow function with type Expected to return a value at the end of arrow function.eslintconsistent-return resolved by passing return in catch with undefined, same behavior more explicit

…and previous tests pass

- File needs better, improved typing and Refactoring for Linter Disables to be removed IF POSSIBLE

- Types and OR check should handle expected behavior

this should allow typescript to infer the type of result.current further improvments needed to add type guards

renamed tests that didn't require code changes to the tests

- Amr, Tiger and myself worked on these commits - Other Raid members in chat assisted - All tests are strongly typed with minimal types to allow for working and made sure tests types were easily usable with types in Pure and Utils file, allow for good UX & DX

…pCallbacks.

codecov · 2020-12-14T09:15:55Z

Codecov Report

Merging #520 (a5754f2) into master (c53b56b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #520   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          127       120    -7     
  Branches        24        22    -2     
=========================================
- Hits           127       120    -7

Impacted Files	Coverage Δ
src/index.ts	`100.00% <ø> (ø)`
src/asyncUtils.ts	`100.00% <100.00%> (ø)`
src/cleanup.ts	`100.00% <100.00%> (ø)`
src/pure.tsx	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53b56b...a5754f2. Read the comment docs.

…peing to waitForValueToChange options

juhanakristian · 2020-12-14T18:46:12Z

@mpeyper The issues you listed in the previous PR have been resolved and if there isn't anything else this should be ready for merging. Let us know what you think 🙂

mpeyper · 2020-12-14T19:15:44Z

Thanks, I'll take a look today.

mpeyper

This is looking very close. A couple of comments here, mostly minor stuff.

src/pure.tsx

test/errorHook.ts

package.json

src/pure.tsx

github-actions · 2020-12-15T03:34:46Z

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

mpeyper · 2021-01-07T03:48:51Z

ok, it's been long enough... I'm going to release this for real now

github-actions · 2021-01-07T03:54:32Z

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

nobrayner and others added 30 commits December 10, 2020 09:27

Added tsconfig.json. Modified eslint config

b7c28dc

Convert src/cleanup.js to TypeScript

a7b9412

Change src/cleanup.ts to use inline types

cdfca10

revert eslintrc

5e5a248

disable eslint for cleanup import

07278d0

this can be reverted when `pure.js` is converted to typescript

convert index to typescript

e8b9dae

just a rename 😅

Worked on typing asyncUtils. Removed deprecated wait. Disabled import…

bc2a6c3

…/no-unresolved for now

Fix incorrect cleanup callback type

f58e7f0

asyncUtils has been updated. Two lines are disabled for eslint.

a8ece29

remove unnecessary eslint disable

7e45893

Prettier was stripping try catch types

b8ddea3

- see: https://prettier.io/blog/2020/08/24/2.1.0.html\#type-annotations-on-catch-clauses-8805httpsgithubcomprettierprettierpull8805-by-fiskerhttpsgithubcomfisker - Updated prettier in local devDeps to resolve directly to newest supported version

comments for review

05e9a38

VoidFunction in place for void until decided behavior for waitFor()

6879cfd

Utilizing OR operator with generic Types allows for desired behavior …

8f902ea

…and previous tests pass

mistakenly left out linter ignores in last commit

2c2908b

Minimum types started for Pure file

58b9b37

- File needs better, improved typing and Refactoring for Linter Disables to be removed IF POSSIBLE

removed comments -- answered in PR

4818ced

- Types and OR check should handle expected behavior

Generic HTML types for initialProps

4c8d1e2

Generic HTML types for initialProps

3f9d853

Generic type for callback and initialProps

d2dadf5

Generics added and CB toplevel same generic pattern added

1dba932

force rebuild with unbound method eslint ignore

6b19d1b

parser issue -- attempt to fix by removing specific TS eslint rule

9604dd7

Newer versions of ESLint might resolve the parser issue

b84a0de

Added configs to get started on test conversion

319cbba

Generic type for resultContainer

ec18c2a

this should allow typescript to infer the type of result.current further improvments needed to add type guards

convert tests that require no changes

7c8ddee

renamed tests that didn't require code changes to the tests

add types to cleanup test

e3ecb24

Test TS Overhaul

d74e947

- Amr, Tiger and myself worked on these commits - Other Raid members in chat assisted - All tests are strongly typed with minimal types to allow for working and made sure tests types were easily usable with types in Pure and Utils file, allow for good UX & DX

tigerabrodi and others added 5 commits December 13, 2020 13:42

update suspenseHook, cache type and the type of the error in catch.

ed2bb4a

cleanup.ts, update the way addCleanup adds another callback to cleanu…

65e4d0c

…pCallbacks.

Made generics more descriptive, made TestHook generic

d51ddc1

Remove some eslint disables that didn't do anything

fb93f4e

Remove DefinitelyTyped reference in CONTRIBUTING.md

1779a85

marcosvega91 and others added 2 commits December 14, 2020 12:58

chore: disable declaration for tests

78c146e

Removes createTimeoutError. Adds constructor to TimeoutError. Adds ty…

9d957ba

…peing to waitForValueToChange options

mpeyper reviewed Dec 15, 2020

View reviewed changes

mpeyper added 11 commits December 15, 2020 13:01

Remove conditional in TestHook for hookProps

d1c36bd

Replace old types defs with referenced types in dependencies

21a1c6e

Remove destructuring of testRenderer

d621cda

Disabled floating promise lint rule globally

900e89c

Refactor TestHook catch to not disable lint rules

4ead36f

Disabled eslint error for while(true)

25509ba

Cleaned up some line warnings from tests

db8a6f3

Added "typecheck" kcd-script to improve "validate" script

f0d080e

Clean up ThrowError type in errorHook tests

84a40ad

Replace VoidFunction with () => void

f33e457

Replace CallableFunction with a more explicit function type

a5754f2

mpeyper changed the base branch from master to beta December 15, 2020 03:18

mpeyper merged commit 251ea70 into testing-library:beta Dec 15, 2020

github-actions bot added the released on @beta label Dec 15, 2020

mpeyper mentioned this pull request Dec 15, 2020

feature/RHTL-68 – server-side-rendering #510

Merged

4 tasks

github-actions bot added the released label Jan 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert to TypeScript #520

Convert to TypeScript #520

juhanakristian commented Dec 14, 2020 •

edited

Loading

codecov bot commented Dec 14, 2020 •

edited

Loading

juhanakristian commented Dec 14, 2020 •

edited

Loading

mpeyper commented Dec 14, 2020

mpeyper left a comment

github-actions bot commented Dec 15, 2020

mpeyper commented Jan 7, 2021

github-actions bot commented Jan 7, 2021

Convert to TypeScript #520

Convert to TypeScript #520

Conversation

juhanakristian commented Dec 14, 2020 • edited Loading

codecov bot commented Dec 14, 2020 • edited Loading

Codecov Report

juhanakristian commented Dec 14, 2020 • edited Loading

mpeyper commented Dec 14, 2020

mpeyper left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 15, 2020

mpeyper commented Jan 7, 2021

github-actions bot commented Jan 7, 2021

juhanakristian commented Dec 14, 2020 •

edited

Loading

codecov bot commented Dec 14, 2020 •

edited

Loading

juhanakristian commented Dec 14, 2020 •

edited

Loading