Skip to content

Commit

Permalink
Make @types/react-dom a regular dependency
Browse files Browse the repository at this point in the history
`@types/react-dom` is used in `types/index.d.ts`, which is an external interface, and thus needs to be declared as a regular rather than a dev dependency so that it is picked up by users of `@testing-library/react`.
  • Loading branch information
fmeum authored Dec 3, 2021
1 parent 8f17a2b commit 5a88092
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@
"license": "MIT",
"dependencies": {
"@babel/runtime": "^7.12.5",
"@testing-library/dom": "^8.0.0"
"@testing-library/dom": "^8.0.0",
"@types/react-dom": "^17.0.0"
},
"devDependencies": {
"@testing-library/jest-dom": "^5.11.6",
"@types/react-dom": "^17.0.0",
"dotenv-cli": "^4.0.0",
"kcd-scripts": "^11.1.0",
"npm-run-all": "^4.1.5",
Expand Down

0 comments on commit 5a88092

Please sign in to comment.