-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct control modifier #1294
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @Rafatcb! Thanks for taking the time to open this one. |
Hi @MatanBobi. Sorry, I didn't realize it was v13. I'm using the latest version ( Although the code is for the current version (v14), I checked Git Blame and the original commit is from PR #581, which went into the v13 release. |
Nice backtracking :) |
The |
Thanks @ph-fritsche :) |
I think we should keep it as it is. The table is for the (legacy) modifiers which had separate implementations in earlier versions. The following sentence is only true for testing-library-docs/docs/ecosystem-user-event.mdx Lines 185 to 187 in 19ee5de
|
If that's the case, I think we can close this one. Thanks @Rafatcb for the effort. |
I was creating a test and
{Ctrl}
wasn't working. I searched through the code and found that the correct modifier is{Control}
, as you can see in user-event/tests/keyboard/parseKeyDef.ts and user-events/tests/utility/type.ts.