-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(tests): apply imperative styles to all tests to be consistent #559
style(tests): apply imperative styles to all tests to be consistent #559
Conversation
fix: apply file accept tokens
Is there a way that we can avoid contributors to use declarative style? For instance, some kind of lint rule of leaving it explicit in the docs |
Just checked it: Actually nothing mentioned in the guideline. Guess it's just that everybody used that imperative style around here recently. I guess everybody just brings their style and each suite reflects who contributed most/first to it. But I like the changes. I think the reports are better to read. And it's consistent with the commit messages where we squash and apply imperative style. |
On a second thought: |
What:
Why: As mentioned by @ph-fritsche in #558, this repo follows the imperative style. There are files using a mix of
declarative
andimperative
test descriptions, we should be consistent and useimperative
style in all tests.How: Replace
declarative
style withimperative
styleChecklist: