Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keyboard): omit keypress with ctrlKey or altKey #615

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Conversation

ph-fritsche
Copy link
Member

@ph-fritsche ph-fritsche commented Mar 23, 2021

What:

Remove keypress and input events for character input if ctrlKey or altKey is true.

Why:

Closes #613

How:

Don't trigger keypress in keyboardImplementation.
This also disables the default keypress behavior (i.e. input for characters).

Checklist:

  • N/A Documentation
  • Tests
  • Ready to be merged

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #615 (7a9a0b8) into master (2b0632a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #615   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines          884       887    +3     
  Branches       333       334    +1     
=========================================
+ Hits           884       887    +3     
Impacted Files Coverage Δ
src/keyboard/keyboardImplementation.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b0632a...7a9a0b8. Read the comment docs.

@ph-fritsche ph-fritsche changed the title fix(keyboard): no keypress with ctrlKey and altKey fix(keyboard): no keypress with ctrlKey or altKey Mar 23, 2021
@ph-fritsche ph-fritsche changed the title fix(keyboard): no keypress with ctrlKey or altKey fix(keyboard): omit keypress with ctrlKey or altKey Mar 23, 2021
@ph-fritsche ph-fritsche merged commit 391e513 into master Mar 23, 2021
@ph-fritsche ph-fritsche deleted the fix-613 branch March 23, 2021 14:11
@github-actions
Copy link

🎉 This PR is included in version 13.0.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: keypress and input event with modifiers
1 participant