Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove internal listeners from user listeners #2872

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Remove internal listeners from user listeners #2872

merged 3 commits into from
Jan 31, 2023

Conversation

juherr
Copy link
Member

@juherr juherr commented Jan 31, 2023 •
edited by krmahadevan
Loading

Fixes #2771

@juherr
Copy link
Member Author

juherr commented Jan 31, 2023

@krmahadevan Feel free to update the branch. I think the test you added in the other branch should be added at least.

@krmahadevan krmahadevan marked this pull request as ready for review January 31, 2023 08:54
@krmahadevan krmahadevan self-requested a review as a code owner January 31, 2023 08:54
@krmahadevan krmahadevan merged commit c087eaa into testng-team:master Jan 31, 2023
@krmahadevan
Copy link
Member

@krmahadevan Feel free to update the branch. I think the test you added in the other branch should be added at least.

I went with ensuring that this changeset does not break any tests. Now I will rebase my branch off of master and see what I should be removing

@missedone missedone mentioned this pull request Jun 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krmahadevan krmahadevan Awaiting requested review from krmahadevan krmahadevan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After upgrading to TestNG 7.5.0, setting ITestResult.status to FAILURE doesn't fail the test anymore
2 participants
@juherr @krmahadevan