Bump versions #3008
Bump versions #3008
Conversation
krmahadevan
force-pushed
the
version_upgrade
branch
from
8281c69
to
d887bd0
Compare
|
@juherr - Please check now |
|
|
||
| version.org.xmlunit..xmlunit-assertj=2.9.0 | ||
| version.org.xmlunit..xmlunit-assertj=2.9.1 | ||
| ## # available=2.9.1 |
There was a problem hiding this comment.
This cannot be removed because there are tests that are using this.
There was a problem hiding this comment.
I'm talking about the commented version, not the dependency.
|
|
||
| version.in.jlibs..jlibs-core=3.0.1 | ||
|
|
||
| version.javax..javaee-api=8.0.1 | ||
| ## # available=8.0.1-b5 |
There was a problem hiding this comment.
This cannot be removed since it is being used here https://github.com/testng-team/testng/blob/master/testng-test-osgi/testng-test-osgi-build.gradle.kts#L21
There was a problem hiding this comment.
I'm talking about the commented version, not the dependency.
There was a problem hiding this comment.
@juherr - They keep getting added back everytime refreshVersions gets executed.
The whole point of basically doing this exercise was because I am noticing that the publish snapshot is failing because there are uncommitted changes https://github.com/testng-team/testng/actions/runs/6941674340/job/18882998284#step:4:93
I am guessing that somehow publish is invoking refreshVersions
So can we please get this change merged so that I can figure out if that solves the problem. If not I would have to add -PallowUncommittedChanges as suggested in the error message.
There was a problem hiding this comment.
Ok for this one. I supposed -b was for beta version that is before the release.
There was a problem hiding this comment.
Even for the other instance where in you had mentioned about removing them, i see the same behaviour. It looks like refreshVersions adds those comments back about new versions, the moment it detects them.
Bumping versions
Closes #2972