This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
Added remove "Get More Favorites" button and other smaller changes #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prefs entries names were all mixed up maybe need a way to migrate to fixed preferences to avoid the mixup affecting users
Added a version to the preferences category identifier to avoid mixing the preferences up
This reverts commit 1930319.
|
I definitely messed those preference entries up, my fault lol. Don't know how I completely missed that, but thanks for fixing it. I'll look into implementing some sort of conversion between settings versions. |
|
Settings conversion has been implemented in 68b239e. Additionally, I've simplified the removal process, but as a result, removals are no longer logged as the log lines reference the preference's name (which would log duplicate lines) and not the specific elements that are removed. Regardless, I think that only error logging is necessary in this case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefs entries ids were all mixed up and got fixed
Added previews of whats being removed by what option in the readme
Added mod dependencies for VRCUK and UIEK to the assembly attributes