Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(t8s-cluster/management-cluster): replace remove with add remove doesn't work when the path doesn't exist 🤦 #1088

Merged
merged 1 commit into from
Aug 9, 2024
Merged

fix(t8s-cluster/management-cluster): replace remove with add remove doesn't work when the path doesn't exist 🤦 #1088

merged 1 commit into from
Aug 9, 2024

Conversation

cwrau
Copy link
Member

@cwrau cwrau commented Aug 9, 2024

No description provided.

@cwrau
fix(t8s-cluster/management-cluster): replace remove with add
784e9c6 
`remove` doesn't work when the `path` doesn't exist 🤦
@cwrau cwrau enabled auto-merge (squash) August 9, 2024 16:09
@cwrau cwrau merged commit 850e3fd into main Aug 9, 2024
12 checks passed
@cwrau cwrau deleted the fix/t8s-cluster/fuck-json-patch branch August 9, 2024 16:11
@teutonet-bot teutonet-bot mentioned this pull request Aug 9, 2024
Merged
@teutonet-bot
Copy link
Contributor

🤖 I have diffed this beep boop

"/$namespace/$kind/$name.yaml" for normal resources
"/$namespace/HelmRelease/$name/$namespace/$kind/$name.yaml" for HelmReleases <- this is recursive
'null' means it's either cluster-scoped or it's in the default namespace for the HelmRelease

[charts/t8s-cluster/ci/artifacthub-values.yaml]({"errors": [{}]})

[charts/t8s-cluster/ci/cidrs-values.yaml]({"errors": [{}]})

[charts/t8s-cluster/ci/injectedCertificateAuthorities-values.yaml]({"errors": [{}]})

[charts/t8s-cluster/ci/hcp-values.yaml]({"errors": [{}]})

[charts/t8s-cluster/ci/securityGroups-values.yaml]({"errors": [{}]})

charts/t8s-cluster/ci/calico-values.yaml

[charts/t8s-cluster/ci/bastion-values.yaml]({"errors": [{}]})

charts/t8s-cluster/values.yaml

[charts/t8s-cluster/ci/gpu-flavor-values.yaml]({"errors": [{}]})

teutonet-bot added a commit that referenced this pull request Aug 9, 2024
@teutonet-bot @github-actions
chore(main): [bot] release t8s-cluster:8.3.2 (#1089)
7b5cbe0 
🤖 I have created a release *beep* *boop*
---


##
[8.3.2](t8s-cluster-v8.3.1...t8s-cluster-v8.3.2)
(2024-08-09)


### Bug Fixes

* **t8s-cluster/management-cluster:** replace `remove` with `add`
`remove` doesn't work when the `path` doesn't exist 🤦
([#1088](#1088))
([850e3fd](850e3fd))


### Miscellaneous Chores

* **t8s-cluster/dependencies:** update common docker tag to v1.2.1
([#1081](#1081))
([88de484](88de484))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@teutonet-bot teutonet-bot mentioned this pull request Aug 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinWolff marvinWolff marvinWolff approved these changes

@tasches tasches Awaiting requested review from tasches tasches is a code owner

@teutonet-bot teutonet-bot Awaiting requested review from teutonet-bot teutonet-bot is a code owner

Assignees

@cwrau cwrau

Labels
t8s-cluster
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwrau @teutonet-bot @marvinWolff