-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(base-cluster/nginx): enable underscores in headers #488
Conversation
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
What does this actually do? I don't find the explanation in the documentation helpful to be honest.
Or let me rephrase this: Why is this even an option and not just working? And why do we need it? From a technical standpoint, this looks fine. |
This is needed for the migration of one customer. It is valid, but not enabled by default in nginx, for whatever reason. I thought it would not hurt to enable this by default everywhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarified questions on the phone.
🤖 I have created a release *beep* *boop* --- ## [4.6.0](base-cluster-4.5.4...base-cluster-v4.6.0) (2023-08-22) ### Features * **base-cluster/nginx:** enable underscores in headers ([#488](#488)) ([b6b8f0a](b6b8f0a)) * **base-cluster/velero:** increase velero resources ([#491](#491)) ([e9cd094](e9cd094)) ### Bug Fixes * **base-cluster/backup:** typos in credential keys ([#497](#497)) ([b990a04](b990a04)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
In preparation of the migration of customer clusters this change is needed.