-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(base-cluster/nginx): add possibility to disable ingress #489
Conversation
charts/base-cluster/templates/monitoring/kube-prometheus-stack/_helpers.yaml
Outdated
Show resolved
Hide resolved
charts/base-cluster/templates/monitoring/kube-prometheus-stack/_helpers.yaml
Outdated
Show resolved
Hide resolved
charts/base-cluster/templates/monitoring/kube-prometheus-stack/_helpers.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the namespace ingress-nginx should not be created if ingress is disabled
Added 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, you're also missing the dashboard in grafana
And the clusterissuer http01 solver
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the helmrepository ingress-nginx and the grafana dashboard can also be excluded if the nginx is disabled.
Also there is a regex left behind for that namespace in alertmanager.additionalAlertRelabelConfigs which can be left as it is but is not necessary if the namespace does not exist.see line 50
I've now disabled the dashboards and disabled the cluster issuer if the ingress is disabled. |
🤖 I have diffed this beep boop"/$namespace/$kind/$name.yaml" for normal resources
|
🤖 I have created a release *beep* *boop* --- ## [4.9.0](base-cluster-4.8.0...base-cluster-v4.9.0) (2023-10-06) ### Features * **base-cluster/nginx:** add possibility to disable ingress ([#489](#489)) ([c5d822a](c5d822a)) * **base-cluster/nginx:** add toggle for snippets ([#599](#599)) ([be13b6a](be13b6a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Add ability to disable ingress.