Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(taBind): Reapply selector handles on focus #779

Merged
merged 1 commit into from
Jul 7, 2015

Conversation

nickknissen
Copy link
Contributor

This fixes image overlay not responding until some edit operation has been performed.
Fixes #777

@pbassut
Copy link
Contributor

pbassut commented Jul 3, 2015

Looks like it broke some tests due something you did with taBind. Mind looking into it?

@nickknissen
Copy link
Contributor Author

Sure thing

@nickknissen nickknissen force-pushed the update-bindings-when-focused branch from b3d2dbc to d55e4e6 Compare July 6, 2015 06:50
@nickknissen
Copy link
Contributor Author

Fixed
Instead of using scope.updateTaBindtaTextElement on textAngular directive i used _reApplyOnSelectorHandlers which was accessible inside taBind directive.

@nickknissen nickknissen force-pushed the update-bindings-when-focused branch 3 times, most recently from 3ccff44 to 62dbded Compare July 6, 2015 07:56
@nickknissen nickknissen changed the title Update bindings when receiving focus. Fix(taBind): Reapply selector handles on focus Jul 6, 2015
Fix image and anchor tags overlay not being shown when element is clicked until a
edit operation has been performed.
@nickknissen nickknissen force-pushed the update-bindings-when-focused branch from 62dbded to 69f4687 Compare July 6, 2015 12:20
@geyang
Copy link
Collaborator

geyang commented Jul 7, 2015

Looks good to me!

pbassut added a commit that referenced this pull request Jul 7, 2015
Fix(taBind): Reapply selector handles on focus
@pbassut pbassut merged commit f05857e into textAngular:master Jul 7, 2015
@nickknissen nickknissen deleted the update-bindings-when-focused branch July 7, 2015 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images doesn't get toolbar when content is loaded asyc
3 participants