Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

chore: swap in libp2p rpc module #19

Merged
merged 1 commit into from
Jul 23, 2021
Merged

chore: swap in libp2p rpc module #19

merged 1 commit into from
Jul 23, 2021

Conversation

sanderpick
Copy link
Member

Nothing wild, just replacing pubsub with https://github.com/textileio/go-libp2p-pubsub-rpc. I also moved marketpeer and finalizer there. Finalizer was started by Anton from Anytype in go-threads. Ideally he can create a repo for that and we could use it... I asked him if he wanted to do that.

@sanderpick sanderpick requested a review from merlinran July 22, 2021 22:30
@sanderpick sanderpick force-pushed the sander/use-rpc-lib branch from 274136a to efad70a Compare July 23, 2021 00:09
@sanderpick
Copy link
Member Author

Fixed some import collisions related to the latest ipfs-lite and the filecoin tooling. Downgrading go-ipns did the trick.

@@ -62,6 +55,4 @@ require (

replace github.com/kilic/bls12-381 => github.com/kilic/bls12-381 v0.0.0-20200820230200-6b2c19996391

replace github.com/ethereum/go-ethereum => github.com/textileio/go-ethereum v1.10.3-0.20210413172519-62e8b38d82b1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped this replacement, but let me know if this was really needed for something.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No these are probably leftovers when extracting this out.

Copy link
Contributor

@merlinran merlinran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Cool to see that piece of work lives on the separate repo.

@sanderpick sanderpick merged commit 32c4e85 into main Jul 23, 2021
@sanderpick sanderpick deleted the sander/use-rpc-lib branch July 23, 2021 18:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants