This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
rename miner-addr to storage-provider-id #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To conform with https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0018.md Also checks its format to fail early Signed-off-by: Merlin Ran <merlinran@gmail.com>
merlinran
force-pushed
the
merlin/rename-storage-provider-id
branch
from
dd55bfc to
b4762e9
Compare
merlinran
commented
Aug 15, 2021
| @@ -48,6 +49,7 @@ var ( | |||
|
|
|||
| dealsListFields = []string{"ID", "DealSize", "DealDuration", "Status", "AskPrice", "VerifiedAskPrice", | |||
| "StartEpoch", "DataURIFetchAttempts", "CreatedAt", "ErrorCause"} | |||
| validStorageProviderID = regexp.MustCompile("^[a-z]0[0-9]+$") | |||
There was a problem hiding this comment.
Actually there are only "f0..." and "t0..." https://docs.filecoin.io/about-filecoin/how-filecoin-works/#id-addresses-f0, but just don't put too rigid rules
| @@ -16,7 +16,7 @@ message Auction { | |||
|
|
|||
| message Bid { | |||
| string auction_id = 1; | |||
| string miner_addr = 2; | |||
| string storage_provider_id = 2; | |||
There was a problem hiding this comment.
I hesitated to do this last time but renaming a field is in fact not a back incompatible change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To conform with https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0018.md (maybe wait for it to be official?)
Also checks its format to fail fast. Saw someone put the actor address there then got cryptic error message.