This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
Update go-ipfs to v0.4.21 + discovery patch #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Signed-off-by: Sander Pick <sanderpick@gmail.com>
Signed-off-by: Sander Pick <sanderpick@gmail.com>
sanderpick
requested review from
andrewxhill,
asutula,
balupton and
carsonfarmer
as code owners
carsonfarmer
approved these changes
Jun 6, 2019
| @@ -146,7 +148,7 @@ func InitIpfs(identity native.Identity, mobile bool, server bool) (*native.Confi | |||
| }, | |||
| DisableBandwidthMetrics: mobile, | |||
| DisableNatPortMap: server, | |||
| EnableRelayHop: false, | |||
| EnableRelayHop: server, | |||
There was a problem hiding this comment.
Just double checking, we only want this enabled when run in 'server' mode?
There was a problem hiding this comment.
I think so... maybe on desktop but probably requires not being behind a NAT
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: ipfs/kubo#6415
Also,
IpfsDHTused in v0.4.21 (v0.0.13)