Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse JavaScript VM and other nits #428

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Reuse JavaScript VM and other nits #428

merged 1 commit into from
Aug 27, 2020

Conversation

sanderpick
Copy link
Member

Closes #423

  • Removes some cumbersome client types
  • Each collection stores its own JS VM and compiled JS functions for resuse
  • Properly returns the writeValidator and readFilter with other collection info in the gRPC API

Signed-off-by: Sander Pick <sanderpick@gmail.com>
@sanderpick sanderpick self-assigned this Aug 27, 2020
@sanderpick sanderpick requested a review from jsign August 27, 2020 20:28
Copy link
Contributor

@jsign jsign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +132 to +141
// GetWriteValidator returns the current collection write validator.
func (c *Collection) GetWriteValidator() []byte {
return c.rawWriteValidator
}

// GetReadFilter returns the current collection read filter.
func (c *Collection) GetReadFilter() []byte {
return c.rawReadFilter
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@sanderpick sanderpick merged commit b544ccc into master Aug 27, 2020
@sanderpick sanderpick deleted the sander/more-nits branch August 27, 2020 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache goja runtime and callables on Collection
2 participants