Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(games): better player substitute events #1218

Merged

Conversation

garrappachc
Copy link
Member

@garrappachc garrappachc commented Sep 12, 2021

Implement substituteRequested, substituteCanceled and playerReplaced events.
Do not get rid of the substituteRequestsChange event as of now, although mark it as deprecated.

@garrappachc garrappachc added the fix A fix to an issue label Sep 12, 2021
@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #1218 (ef795c7) into master (f3118c4) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1218      +/-   ##
==========================================
- Coverage   95.11%   94.98%   -0.13%     
==========================================
  Files         181      181              
  Lines        3624     3631       +7     
  Branches      326      326              
==========================================
+ Hits         3447     3449       +2     
- Misses        175      180       +5     
  Partials        2        2              
Impacted Files Coverage Δ
src/events/events.ts 100.00% <100.00%> (ø)
src/games/services/player-substitution.service.ts 98.41% <100.00%> (+0.05%) ⬆️
src/games/services/rcon-factory.service.ts 33.33% <0.00%> (-55.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3118c4...ef795c7. Read the comment docs.

@garrappachc garrappachc merged commit 3865b18 into tf2pickup-org:master Sep 13, 2021
@garrappachc garrappachc deleted the better-substitution-events branch September 13, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix to an issue
Development

Successfully merging this pull request may close these issues.

1 participant