Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(game-servers): serveme.tf integration #1520

Merged
merged 15 commits into from
Mar 30, 2022

Conversation

garrappachc
Copy link
Member

No description provided.

@garrappachc garrappachc added the enhancement New feature or request label Mar 14, 2022
@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1520 (7d19157) into master (d5d5ef9) will decrease coverage by 0.16%.
The diff coverage is 92.02%.

@@            Coverage Diff             @@
##           master    #1520      +/-   ##
==========================================
- Coverage   95.20%   95.03%   -0.17%     
==========================================
  Files         198      204       +6     
  Lines        3941     4090     +149     
  Branches      382      387       +5     
==========================================
+ Hits         3752     3887     +135     
- Misses        178      192      +14     
  Partials       11       11              
Impacted Files Coverage Δ
src/environment-schema.ts 100.00% <ø> (ø)
src/environment/environment.ts 90.90% <0.00%> (-4.33%) ⬇️
src/games/services/game-launcher.service.ts 94.44% <ø> (+1.11%) ⬆️
src/main.ts 0.00% <0.00%> (ø)
src/games/services/server-configurator.service.ts 97.61% <50.00%> (-1.17%) ⬇️
src/app.ts 66.66% <66.66%> (ø)
...erveme-tf/serveme-tf-game-server-model.provider.ts 80.00% <80.00%> (ø)
...servers/providers/game-servers-providers.module.ts 90.90% <85.71%> (-9.10%) ⬇️
...-servers/providers/serveme-tf/serveme-tf.module.ts 87.50% <87.50%> (ø)
...viders/serveme-tf/models/serveme-tf-game-server.ts 94.11% <94.11%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5d5ef9...7d19157. Read the comment docs.

@garrappachc garrappachc marked this pull request as ready for review March 23, 2022 09:24
Copy link
Member

@c43721 c43721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's outstanding issues in regards to using module ref in the wrong way @garrappachc

src/main.ts Show resolved Hide resolved
src/app.ts Show resolved Hide resolved
@c43721 c43721 self-requested a review March 26, 2022 00:49
@garrappachc garrappachc merged commit 6064170 into tf2pickup-org:master Mar 30, 2022
@garrappachc garrappachc deleted the serveme-tf-integration branch March 30, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants