fix: handle setting initial skill of a player

src/players/services/player-skill.service.spec.ts

@@ -16,6 +16,7 @@ import { DiscordService } from '@/discord/services/discord.service';
 import { Environment } from '@/environment/environment';
 import { Events } from '@/events/events';
 import { Tf2ClassName } from '@/shared/models/tf2-class-name';
+import { skillChanged } from '@/discord/notifications';
 
 jest.mock('./players.service');
 jest.mock('./future-player-skill.service');
@@ -193,6 +194,32 @@ describe('PlayerSkillService', () => {
       });
     });
 
+    describe('when initializing player skill', () => {
+      let newPlayer: DocumentType<Player>;
+
+      beforeEach(async () => {
+        // @ts-expect-error
+        newPlayer = await playersService._createOne();
+      });
+
+      it('should notify admins on discord', async () => {
+        const spy = jest.spyOn(discordService.getAdminsChannel(), 'send');
+        await service.setPlayerSkill(newPlayer.id, new Map([[Tf2ClassName.soldier, 2]]));
+        expect(spy).toHaveBeenCalledWith({
+          embed: {
+            ...skillChanged({
+              playerName: 'fake_player_2',
+              oldSkill: new Map(),
+              newSkill: new Map(([[Tf2ClassName.soldier, 2]])),
+              playerProfileUrl: `FAKE_CLIENT_URL/player/${newPlayer.id}`,
+              adminResponsible: undefined,
+            }),
+            timestamp: expect.any(Date),
+          },
+        });
+      });
+    });
+
     describe('when there is no such player', () => {
       it('should fail', async () => {
         await expect(service.setPlayerSkill(new ObjectId().toString(), new Map([[Tf2ClassName.scout, 1]]))).rejects.toThrowError('no such player');

src/players/services/player-skill.service.ts

@@ -62,7 +62,7 @@ export class PlayerSkillService implements OnModuleInit {
       throw new Error('no such player');
     }
 
-    const oldSkill = await this.playerSkillModel.findOne({ player: playerId });
+    const oldSkill = await this.playerSkillModel.findOne({ player: playerId }) || { skill: new Map() };
     const ret = await this.playerSkillModel.findOneAndUpdate({ player: playerId }, { skill }, { new: true, upsert: true });
 
     for (const [key, value] of ret.skill) {