Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): docker image build improvements #924

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

garrappachc
Copy link
Member

  • don't produce type definitions (*.d.ts)
  • don't write source maps
  • use node user to run the app inside docker

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #924 (33ddc8a) into master (60ae7c3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #924   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         116      116           
  Lines        2556     2556           
  Branches      267      267           
=======================================
  Hits         2391     2391           
  Misses        164      164           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60ae7c3...33ddc8a. Read the comment docs.

@garrappachc garrappachc merged commit 490ba60 into tf2pickup-org:master Mar 17, 2021
@garrappachc garrappachc deleted the dockerfile-fixes branch March 17, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant