Add support for deriving instances via Generically
#108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfausak
commented
Nov 7, 2024
| import qualified GHC.Generics as Generics | ||
| import qualified Witch.From as From | ||
|
|
||
| class GFrom s t where |
There was a problem hiding this comment.
These are all implementation details. End users wouldn't need to know or care about GFrom.
There was a problem hiding this comment.
That being said, I should either hang some documentation on this or on the From s (Generically t) instance.
tfausak
commented
Nov 7, 2024
|
In terms of motivation, I think this would mostly be useful for application code. Witch doesn't provide instances for tuples, for example. And I don't want to provide them even though they could be derived Perhaps something could also be done for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107.