Fix innoverio.vscode-dbt-power-user Exasol errors #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The innoverio.vscode-dbt-power-user VScode extension expects all errors coming from DBT adapters to be raised as DBT errors. The dbt-exasol adapter was raising Exasol DB errors as pyexasol's QueryError error type and so this caused problems in the vscode extension. This commit changes the error to the standard DBT DB error type.
tglunde
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
Hi @peterkioko , thank you very much for this contribution. Happy to accept this change!
tglunde
pushed a commit
that referenced
this pull request
Jun 12, 2023
The innoverio.vscode-dbt-power-user VScode extension expects all errors coming from DBT adapters to be raised as DBT errors. The dbt-exasol adapter was raising Exasol DB errors as pyexasol's QueryError error type and so this caused problems in the vscode extension. This commit changes the error to the standard DBT DB error type. Co-authored-by: Peter Kioko <kioko@grantstreet.com>
tglunde
pushed a commit
that referenced
this pull request
Jun 12, 2023
The innoverio.vscode-dbt-power-user VScode extension expects all errors coming from DBT adapters to be raised as DBT errors. The dbt-exasol adapter was raising Exasol DB errors as pyexasol's QueryError error type and so this caused problems in the vscode extension. This commit changes the error to the standard DBT DB error type. Co-authored-by: Peter Kioko <kioko@grantstreet.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The innoverio.vscode-dbt-power-user VScode extension expects all errors coming from DBT adapters to be raised as DBT errors. The dbt-exasol adapter was raising Exasol DB errors as pyexasol's QueryError error type and so this caused problems in the vscode extension.
This commit changes the error to the standard DBT DB error type.