Breakout Room 8: Update main.py #12
Conversation
There was a problem hiding this comment.
I would suggest that you have a guard clause to prevent non-alpha characters to be submitted in the program. I was able to enter numerics and spaces which did not meet the requirements.
This also could be a function itself so that we can reuse that function for other parts of our program.
🐰
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") | ||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () | ||
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
| print ("------------------------------------------") |
There was a problem hiding this comment.
Consider using a f-string for readability✨ ✨
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") |
There was a problem hiding this comment.
seond_nounThere is a typo for the above variable.
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
| loop = 1 | |||
| while (loop < 9): | |||
There was a problem hiding this comment.
The loop is currently running much less than the required amount.
The game should loop so the user can create 10 stories.
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
There was a problem hiding this comment.
Consider using a for loop starting here and have it loop 10 times. 🐶
Also for Python, we use # for comments. Unfortunately, this is not Javascript :(
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" | ||
| loop = loop + 1 |
There was a problem hiding this comment.
I think using syntactic sugar would be so awesome here! :)
There was a problem hiding this comment.
I would suggest that you have a guard clause to prevent non-alpha characters to be submitted in the program. I was able to enter numerics and spaces which did not meet the requirements.
This also could be a function itself so that we can reuse that function for other parts of our program.
🐰
| print ("For a duck may be somebody's", seond_noun,",") | ||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () |
There was a problem hiding this comment.
There is an empty print statement here. It's so lonely! We could incorporate another way to create a whitespace between the lines.
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" |
There was a problem hiding this comment.
If you want to reset the loop, you would want to do this before the while loop, I believe.
No description provided.