Breakout Room 15: Update main.py #5
Open
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
| loop = 1 | |||
| while (loop < 9): | |||
There was a problem hiding this comment.
loop will need to run for <24 instead of 9
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
There was a problem hiding this comment.
It is more typical in Python to include comments using # instead if /
| @@ -1 +1,23 @@ | |||
| #Mad Libs Generator Project | |||
| //Loop back to this point once code finishes | |||
| loop = 1 | |||
| while (loop < 9): | |||
There was a problem hiding this comment.
Consider changing that 9 to 11 - would a for loop be a better fit here?
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") |
There was a problem hiding this comment.
Typo alert! Change seond to second!
Comment on lines
+13
to
+21
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") | ||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () | ||
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
| print ("------------------------------------------") |
There was a problem hiding this comment.
Would this be more efficient as a single f string?
Additionally, consider injecting some humor into your MadLib. This doesn't give our user many opportunities for laughter!
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
| // Loop back to "loop = 1" | ||
| loop = loop + 1 |
There was a problem hiding this comment.
Consider adding a feature where the user can exit after creating a MadLib, rather than looping over 10 times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.