Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout Room 13: Update main.py #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tgoslee
Copy link
Owner

@tgoslee tgoslee commented May 10, 2022

No description provided.

// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to have a typo for the variable. Did you mean second_noun?

Comment on lines +3 to +4
loop = 1
while (loop < 9):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't result in 10 stories for the user. Consider revising the loop variable and/or the ending range.

Comment on lines +6 to +11
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these to a data structure such as a dictionary might be useful for printing or organizing the story.

Comment on lines +13 to +21
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A helper function might be useful here for printing the story. It would keep the main code cleaner.
Also, an f-string and a single print statement could be helpful for readability.

print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
loop = loop + 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shorter way for this same code would be

loop += 1

Comment on lines +3 to +23
loop = 1
while (loop < 9):
// All the questions that the program asks the user
noun = input("Choose a noun: ")
plural_noun = input("Choose a plural noun: ")
second_noun = input("Choose a noun: ")
place = input("Name a place: ")
adjective = input("Choose an adjective (Describing word): ")
third_noun = input("Choose a noun: ")
// Displays the story based on the users input
print ("------------------------------------------")
print ("Be kind to your",noun,"- footed", plural_noun)
print ("For a duck may be somebody's", seond_noun,",")
print ("Be kind to your",plural_noun,"in",place)
print ("Where the weather is always",adjective,".")
print ()
print ("You may think that is this the",third_noun,",")
print ("Well it is.")
print ("------------------------------------------")
// Loop back to "loop = 1"
loop = loop + 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider putting all of this into a function that could be called for each story

@@ -1 +1,23 @@
#Mad Libs Generator Project
//Loop back to this point once code finishes
loop = 1
while (loop < 9):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A for loop might be useful here since we already know how many times it runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants