Merge pull request #1791 from tgstation/MinorSpuriousDebugInfo [DMDep…

…loy][TGSDeploy] v6.3.1: Fix a 500 error. Add a debug message
tgstation · Feb 27, 2024 · cde1ea6 · cde1ea6
2 parents 57512a4 + 436938e
commit cde1ea6
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/build/Version.props b/build/Version.props
@@ -3,7 +3,7 @@
   <!-- Integration tests will ensure they match across the board -->
   <Import Project="WebpanelVersion.props" />
   <PropertyGroup>
-    <TgsCoreVersion>6.3.0</TgsCoreVersion>
+    <TgsCoreVersion>6.3.1</TgsCoreVersion>
     <TgsConfigVersion>5.1.0</TgsConfigVersion>
     <TgsApiVersion>10.2.0</TgsApiVersion>
     <TgsCommonLibraryVersion>7.0.0</TgsCommonLibraryVersion>

diff --git a/src/Tgstation.Server.Host/Utils/SignalR/ComprehensiveHubContext.cs b/src/Tgstation.Server.Host/Utils/SignalR/ComprehensiveHubContext.cs
@@ -147,8 +147,9 @@ public void AbortUnauthedConnections(User user)
 					return old;
 				});
 
-			foreach (var context in connections!)
-				context.Abort();
+			if (connections != null)
+				foreach (var context in connections)
+					context.Abort();
 		}
 	}
 }
diff --git a/tests/Tgstation.Server.Tests/Live/Instance/ChatTest.cs b/tests/Tgstation.Server.Tests/Live/Instance/ChatTest.cs
@@ -6,6 +6,8 @@
 
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 
+using Newtonsoft.Json;
+
 using Tgstation.Server.Api.Models;
 using Tgstation.Server.Api.Models.Request;
 using Tgstation.Server.Api.Models.Response;
@@ -196,7 +198,7 @@ async Task RunDiscord(CancellationToken cancellationToken)
 				.OrderBy(x => x.StartedAt)
 				.FirstOrDefault();
 
-			Assert.IsNotNull(reconnectJob);
+			Assert.IsNotNull(reconnectJob, $"Jobs: {JsonConvert.SerializeObject(jobs)}");
 			await WaitForJob(reconnectJob, 60, false, null, cancellationToken);
 
 			var channelIdStr = Environment.GetEnvironmentVariable("TGS_TEST_DISCORD_CHANNEL");