Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #233 #234

Merged
merged 1 commit into from
May 23, 2020
Merged

Fix for #233 #234

merged 1 commit into from
May 23, 2020

Conversation

NetizenAbel
Copy link
Collaborator

Context / Background

What change is being introduced by this PR?

  • Using the error-reporter, looking at the files related.
  • I added '../' before bootstrap.
  • Directly, this fixes the bug.

How will this be tested?

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #234 into master will increase coverage by 13.97%.
The diff coverage is 79.58%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #234       +/-   ##
===========================================
+ Coverage   35.46%   49.43%   +13.97%     
===========================================
  Files          11       12        +1     
  Lines         595      981      +386     
  Branches      102      176       +74     
===========================================
+ Hits          211      485      +274     
- Misses        340      433       +93     
- Partials       44       63       +19     
Impacted Files Coverage Δ
js/calendar.js 0.00% <0.00%> (ø)
main.js 0.00% <0.00%> (ø)
js/classes/Calendar.js 71.76% <84.70%> (ø)
js/date-aux.js 100.00% <100.00%> (ø)
js/user-preferences.js 87.95% <100.00%> (-2.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ff853e...6e6cb4b. Read the comment docs.

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised by how:

  1. This was the root cause
  2. The coverage increases so much without writing any tests ahahah

@thamara thamara added this to the v1.5.2 milestone May 23, 2020
@thamara thamara merged commit bdce1b5 into thamara:master May 23, 2020
@NetizenAbel
Copy link
Collaborator Author

I'm surprised by how:

  1. This was the root cause
  2. The coverage increases so much without writing any tests ahahah

I was shocked myself! I thought I had to be missing something for a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants