Fixing preferences derived loading #249
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context / Background
This is fixing an issue in the getDerivedPrefsFromLoadedPrefs method on the user-preferences.js file.
The method was evaluating the loaded preferences in regards to the default ones, but ignoring all the changes it did at the end by returning the wrong variable.
This caused issues when changing the number of keys in the default preferences: for instance, the new key for view in the other PR.
What change is being introduced by this PR?
Returning the correct "derived" variable now.
How will this be tested?
All tests ran fine. Adding or removing lines from preferences stops it from being reset to default.