-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #258: Fixing crash when changing network while opening TTL #267
Conversation
Codecov Report
@@ Coverage Diff @@
## master #267 +/- ##
==========================================
+ Coverage 55.08% 56.64% +1.56%
==========================================
Files 13 13
Lines 1220 1234 +14
Branches 218 221 +3
==========================================
+ Hits 672 699 +27
+ Misses 480 468 -12
+ Partials 68 67 -1
Continue to review full report at Codecov.
|
62f9154
to
6c14a71
Compare
I mean, it doesn't really fiiiix, it just hides the exception and exits gracefully, I wonder if we can or should pursue fixing it, as it's a corner case. |
Yeah, since the stack trace doesn't really say anything, I couldn't be sure if there is one thing in the code that is leading to this error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess we don't really need to pursue it. Can you add a changelog entry, please?
6c14a71
to
9342e1e
Compare
Added |
Related issue
Closes #258: Fixing crash when changing network while opening TTL
Context / Background
While changing network and opening TTL at the same time, a network err exception is thrown and never caught anywhere.
What change is being introduced by this PR?
This PR adds a global catcher just for this exception.
How will this be tested?
Forced the same conditions that caused the issue and didn't see it happen :)