Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Enable auto downsampling #218

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

srueg
Copy link
Contributor

@srueg srueg commented Apr 8, 2021

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Enable --query.auto-downsampling for query by default.

Verification

Generation works as expected in committed files.

Signed-off-by: Simon Rüegg <simon@rueggs.ch>
@srueg srueg force-pushed the query-auto-downsample branch from ec4b405 to f7280ea Compare April 8, 2021 08:21
@metalmatze
Copy link
Contributor

Nice! LGTM.
Maybe @kakkoyun wants to take another look.

@srueg
Copy link
Contributor Author

srueg commented Apr 14, 2021

Ping @kakkoyun

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution.

@kakkoyun kakkoyun merged commit 8698db1 into thanos-io:main Apr 14, 2021
@srueg srueg deleted the query-auto-downsample branch April 14, 2021 12:22
srueg added a commit to projectsyn/component-thanos that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants