add bucket replicate component #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
yeya24
force-pushed
the
add-bucket-replicate
branch
from
24f0dec to
ed8dc21
Compare
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
yeya24
force-pushed
the
add-bucket-replicate
branch
from
ed8dc21 to
2e8cf8d
Compare
kakkoyun
approved these changes
Aug 19, 2021
yeya24
commented
Aug 21, 2021
Thanks for catching this. I updated some minio manifests mistakenly and I already changed them back. PTAL |
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
|
Ready for review again. CC @kakkoyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye ben.ye@bytedance.com
Changes
Add a new bucket replicate component. The libsonnet file is modified based on the bucket.libsonnet file.
Verification
We have been using this component in production.