Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Receive PDB to policy/v1 #284

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Change Receive PDB to policy/v1 #284

merged 1 commit into from
Aug 30, 2022

Conversation

saswatamcode
Copy link
Member

This PR changes Receive PDB apiVersion to policy/v1 as policy/v1beta1 is set to be deprecated since K8s v1.21 and will be removed in v1.25 https://kubernetes.io/docs/reference/using-api/deprecation-guide/#poddisruptionbudget-v125.

Currently we get warnings while deploying like,

Warning: policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget
  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Change Receive PDB to policy/v1
  • Update kubeconform make target to K8s v1.21

Verification

Tested locally.

@saswatamcode
Change Receive PDB to policy/v1
08a4133 
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
@bwplotka bwplotka merged commit 826595f into thanos-io:main Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saswatamcode @philipgough @bwplotka