Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding networkpolicy for thanos components #315

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

adding networkpolicy for thanos components #315

wants to merge 3 commits into from

Conversation

harsh-ps-2003
Copy link

@harsh-ps-2003 harsh-ps-2003 commented Jan 6, 2024 •
edited
Loading

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixes #314
Adding network policies for all Thanos components.

@harsh-ps-2003
adding networkpolicy for thanos components
3903229 
Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
@harsh-ps-2003
Copy link
Author

@metalmatze can you review the PR please. If it looks good I will add the changelog.

@metalmatze
Copy link
Contributor

Thanks!
From looking at the code changes and now having compiled and run this, the change seems good overall. 👍

Some CI failures need to be fixed. Run jsonnetfmt -i $file on your changed files.

@harsh-ps-2003
fixing commas
6dd9284 
Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
@harsh-ps-2003
Copy link
Author

Thanks for the review! I had some syntax errors that I fixed now! @metalmatze

@harsh-ps-2003
adding changelog entry
7b22d2f 
Signed-off-by: Harsh Pratap Singh <harshpratapsingh8210@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NetworkPolicy to all components
2 participants
@harsh-ps-2003 @metalmatze