Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add host anti-affinity to receive and querier #84

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Add host anti-affinity to receive and querier #84

merged 1 commit into from
Jan 7, 2020

Conversation

metalmatze
Copy link
Contributor

We would prefer if Kubernetes schedules the Receive and Querier Pods to individual nodes.

/cc @kakkoyun @squat @bwplotka @brancz

@metalmatze
Add host anti-affinity to receive and querier
4da1b2e 
Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
@metalmatze metalmatze requested review from kakkoyun and squat January 7, 2020 15:08
bwplotka
bwplotka approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Just to clarify: This makes sure queriers are on separate nodes and receivers are on separate nodes, but receiver AND querier can be together on node (: I think it makes sense 👍

kakkoyun
kakkoyun approved these changes Jan 7, 2020
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metalmatze metalmatze merged commit 0c90793 into thanos-io:master Jan 7, 2020
@metalmatze metalmatze deleted the anti-affinity branch January 7, 2020 15:19
@paulfantom paulfantom mentioned this pull request Jan 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

@kakkoyun kakkoyun kakkoyun approved these changes

@squat squat Awaiting requested review from squat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@metalmatze @kakkoyun @bwplotka