-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S3: Support specifying S3 storage class #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanrh
changed the title
Enable specifying S3 storage class
Support specifying S3 storage class
Sep 8, 2022
juanrh
changed the title
Support specifying S3 storage class
S3: Support specifying S3 storage class
Sep 8, 2022
juanrh
force-pushed
the
thanos-5663
branch
2 times, most recently
from
September 8, 2022 09:36
8a06c92
to
55c8089
Compare
bwplotka
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Proposed some changes, otherwise LGTM (:
CHANGELOG.md
Outdated
@@ -14,6 +14,7 @@ We use *breaking :warning:* to mark changes that are not backward compatible (re | |||
|
|||
### Added | |||
- [#15](https://github.com/thanos-io/objstore/pull/15) Add Oracle Cloud Infrastructure Object Storage Bucket support. | |||
- [#25](https://github.com/thanos-io/objstore/pull/25) Thanos Objstore S3: Support specifying S3 storage class. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- [#25](https://github.com/thanos-io/objstore/pull/25) Thanos Objstore S3: Support specifying S3 storage class. | |
- [#25](https://github.com/thanos-io/objstore/pull/25) S3: Support specifying S3 storage class. |
juanrh
force-pushed
the
thanos-5663
branch
2 times, most recently
from
September 9, 2022 16:41
3b1f06f
to
a5ee588
Compare
Allow specifying a storage class for S3 object storage in config.put_user_metadata:X-Amz-Storage-Class. If not specified then STANDARD is used by default. Solves: thanos-io/thanos#5663 Signed-off-by: Juan Rodriguez Hortala <juanrh@redhat.com>
matej-g
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes
For thanos-io/thanos#5663, enable specifying S3 storage class by specifying it in config.put_user_metadata. For example launching the sidecar with a
--objstore.config-file
as follows stores all S3 files with storage class ofSTANDARD_IA
while using the following config file uses the default storage class of
STANDARD
Verification
Added unit tests.
Manual tests launching the sidecar with the two configurations listed above, doing
rm ${PROM_ROOT}/data/thanos.shipper.json
before that to force uploading files, and with a prometheus instance with small block duration to force upload.