Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContextWithTracer() #33

Merged
merged 2 commits into from
Oct 25, 2022
Merged

Conversation

pracucci
Copy link
Contributor

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Currently it's not possible to set the tracerKey expected by the package to get the object store client tracing work. In this PR I'm adding the function ContextWithTracer() which is a copy of the Thanos one. Then, in Thanos, we can remove the function is use this one instead.

Fixes #30

Verification

N/A

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💪🏽

@bwplotka bwplotka merged commit 0ea26d7 into thanos-io:main Oct 25, 2022
@pracucci pracucci deleted the add-ContextWithTracer branch October 26, 2022 07:55
phillebaba pushed a commit to phillebaba/objstore that referenced this pull request Nov 9, 2022
* Add ContextWithTracer()

Signed-off-by: Marco Pracucci <marco@pracucci.com>

* Added CHANGELOG entry

Signed-off-by: Marco Pracucci <marco@pracucci.com>

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracing doesn't work
2 participants