Replace method IsCustomerManagedKeyError
for a more generic IsAccessDeniedErr
on the bucket interface.
#71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replace the
IsCustomerManagedKeyError
method for a more genericIsAccessDeniedErr
method and implement it multiples provides.This method can be useful for the projects consuming this lib to identify AccessDenied errors from other types of errors and for, for example, avoid retries.
I think is safe to remove the
IsCustomerManagedKeyError
for now as is a very recent change and is being used only in cortex for now.Changes
IsCustomerManagedKeyError
method from the objstore interfaceIsAccessDeniedErr
method on the objstore interface and implement it on multiples providers.