-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: Add find overlap block UI #4462
Conversation
Nice work @adzshaf , can't wait to see this in action! 💜 |
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
4deba3e
to
03b7362
Compare
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! Two small suggestions from my side and it's good :)
Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
@squat ready to be merged 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Yang Hu <yhuz@amazon.com> ui: Add find overlap block UI (thanos-io#4462) * feat(ui): add find overlap blocksui Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * fix(ui): delete comments Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * refactor: refactor find overlap blocks Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * fix: remove unnecessary changes Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * fix: fix search input Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * feat: add query param for find overlapping Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * docs: add changelog Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * docs: move changelog to added Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com> * fix: change wording Signed-off-by: Shafiya Adzhani <adz.arsym@gmail.com>
Changes
This PR is part of LFX Mentorship project to improve Block Viewer UI (issue: #3112). We want to add feature so user can find overlapping blocks easily.
Verification
When we haven't enable find overlapping block yet:
Example
enable find overlapping block
:Tested on local using
make quickstart
cc: @onprem @squat